asolimando commented on a change in pull request #2573:
URL: https://github.com/apache/calcite/pull/2573#discussion_r725428688
##########
File path: core/src/main/java/org/apache/calcite/jdbc/JavaTypeFactoryImpl.java
##########
@@ -343,8 +343,14 @@ private SyntheticRecordType register(
/** Creates a synthetic Java class whose fields have the same names and
* relational types. */
private Type createSyntheticType(RelRecordType type) {
- final String name =
- "Record" + type.getFieldCount() + "_" + syntheticTypes.size();
+ final StringBuilder sb = new StringBuilder();
Review comment:
I think a test using `CalciteAssert.typeIs` is needed here, the change
might alter those results?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
