snuyanzin commented on a change in pull request #2573:
URL: https://github.com/apache/calcite/pull/2573#discussion_r725444614
##########
File path:
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableRelImplementor.java
##########
@@ -327,6 +327,9 @@ private static ClassDeclaration classDecl(
for (Types.RecordField field : type.getRecordFields()) {
MethodCallExpression compareCall;
try {
+ if (!Comparable.class.isAssignableFrom(field.getType().getClass())) {
Review comment:
`Types.isAssignableFrom` could check if one type is assignable from
another type. It seems not my case as
here need to check if a type is assignable from a constant class/interface
`Comparable` => one argument is a Type and the other is `Comparable.class`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
