tledkov-gridgain commented on a change in pull request #2590:
URL: https://github.com/apache/calcite/pull/2590#discussion_r731829663
##########
File path:
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableValues.java
##########
@@ -55,14 +55,14 @@
public class EnumerableValues extends Values implements EnumerableRel {
/** Creates an EnumerableValues. */
private EnumerableValues(RelOptCluster cluster, RelDataType rowType,
- ImmutableList<ImmutableList<RexLiteral>> tuples, RelTraitSet traitSet) {
+ List<? extends List<RexLiteral>> tuples, RelTraitSet traitSet) {
Review comment:
Thanks for you attention.
I have no opinion about specification the list elements: `RexLiteral` or any
it's child.
I just create PR to illustrate and starts the discussion on the devlist
about **remove guava classes from public API** if it is possible. What do you
think about the patch motivation in general?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
