tledkov-gridgain commented on a change in pull request #2590:
URL: https://github.com/apache/calcite/pull/2590#discussion_r731939361
##########
File path:
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableValues.java
##########
@@ -55,14 +55,14 @@
public class EnumerableValues extends Values implements EnumerableRel {
/** Creates an EnumerableValues. */
private EnumerableValues(RelOptCluster cluster, RelDataType rowType,
- ImmutableList<ImmutableList<RexLiteral>> tuples, RelTraitSet traitSet) {
+ List<? extends List<RexLiteral>> tuples, RelTraitSet traitSet) {
Review comment:
@zabetak, Thanks for clarification.
My point was:
Calcite is a framework. The transitive dependencies may be shaded, but when
it is used in public API we have to use guava in the code that is uses Calcite.
In case the Apache Ignite we try to minimize external dependencies because it
is a platform and may be embedded. Guava is one of the most popular library
and there is big chance that the Ignite's users will be use Guava at the
project with Ignite. So, a Guava version conflict is very likely. Moreover,
Guava is changed frequently and new versions are released. I understand that it
isn't problem of Calcite. I close the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
