zabetak commented on a change in pull request #2590:
URL: https://github.com/apache/calcite/pull/2590#discussion_r731849003
##########
File path:
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableValues.java
##########
@@ -55,14 +55,14 @@
public class EnumerableValues extends Values implements EnumerableRel {
/** Creates an EnumerableValues. */
private EnumerableValues(RelOptCluster cluster, RelDataType rowType,
- ImmutableList<ImmutableList<RexLiteral>> tuples, RelTraitSet traitSet) {
+ List<? extends List<RexLiteral>> tuples, RelTraitSet traitSet) {
Review comment:
About removing Guava from the public API there have been discussions in
the past:
https://lists.apache.org/thread.html/ra9c695b51dd6fc9b528a2c94f301cc966839983964c2d2fa52d23a8f%40%3Cdev.calcite.apache.org%3E
https://lists.apache.org/thread.html/5988348d9451255da3b45cb67e92a375d337859711fd0b66c9f42407%40%3Cdev.calcite.apache.org%3E
@tledkov-gridgain If you have new elements to bring to the table I would
encourage you to revive those discussions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
