vlsi commented on pull request #2623: URL: https://github.com/apache/calcite/pull/2623#issuecomment-992486178
@korlov42 , What do you suggest for cases like https://github.com/apache/calcite/blob/f3c09365c2eecbb5198d9acbef638f76053a49a9/mongodb/src/main/java/org/apache/calcite/adapter/mongodb/MongoRules.java#L302-L318 ? It looks like you did not refactor `mongodb` adapter, and I guess it would result in loss of semantics. It looks like `variablesSet` would be discarded. The sad thing is Calcite users would get similar issues: they would get wrong results/wrong plans, and nobody would know the reason. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
