jacques-n commented on pull request #2622: URL: https://github.com/apache/calcite/pull/2622#issuecomment-996854742
> This change adds new a package repository. Are we OK with that? I did identify the addition and was okay with it given the following: - it was constrained to test dependencies - it was constrained to a single module - it seemed benign I didn't know about the ability to do content filtering or I would have asked that it was included. However, if many others have a strong aversion, we can revert. What do we think we should suggest people do in this kind of situation? Especially in this situation where new functionality isn't being added here which sources a new repo, instead existing dependency jars have moved to a new repo. > Category X license I didn't realize that the ES license change was in a minor version (sigh). That being said, I don't see a problem with this patch. We already depend on category X licenses for build/test (JMH is an example, I believe) and this is consistent with ASF policies. Category X are prohibited in source releases and convenience binaries and I don't believe this change introduces any violation of that. As I understand it, the rest client we depend on for non-test code remains ASL2.0 licensed (only the "highlevel" library moved to the category X licenses: [ll license](https://www.elastic.co/guide/en/elasticsearch/client/java-rest/current/_license.html), [ll-hl distinction](https://stackoverflow.com/questions/62340904/elasticsearch-rest-high-level-client-vs-elasticsearch-rest-client)). #### Summary - This seemed like a relatively innocuous change which is why I merged it. If there is a strong discomfort to the inclusion of a new repository (even at this constrained level), we can revert this and ask the contributor to find an alternative path. - If we are uncomfortable using category X licenses in the ES test module, we should probably remove ES as a supported adapter and either deprecate entirely or move to the AWS opensearch fork. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
