jacques-n commented on pull request #2622: URL: https://github.com/apache/calcite/pull/2622#issuecomment-996974297
> java.sql.Connection is licensed under GPL + Classpath_Exception You're mixing api with implementation. There are implementations of java.sql.Connection that are ASL2.0 such as [here](https://github.com/apache/harmony/blob/trunk/classlib/modules/sql/src/main/java/java/sql/Connection.java). > there's no way JMH is forbidden I didn't say JMH is forbidden, I said it is Category X according to Apache legal (GPL+CPE). Category X is allowed as optional and for build. > I have no idea if the problematic classes are used for testing ES adapter only or if they are used for implementing it. I did do the legwork on review. For reference from gradle build file (with my added license notes): ```kotlin // Category A api("org.elasticsearch.client:elasticsearch-rest-client") // Category A (according to github license, Laurent comment not withstanding) testImplementation("org.codelibs.elasticsearch.module:lang-painless") testImplementation("org.codelibs.elasticsearch.module:scripting-painless-spi") // Category X testImplementation("org.elasticsearch:elasticsearch") ``` So unless I misunderstand the gradle syntax, only the tests are relying on Category X (same as JMH). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
