ILuffZhe commented on a change in pull request #2698:
URL: https://github.com/apache/calcite/pull/2698#discussion_r840706530
##########
File path:
elasticsearch/src/main/java/org/apache/calcite/adapter/elasticsearch/ElasticsearchSchemaFactory.java
##########
@@ -53,6 +60,24 @@
private static final Logger LOGGER =
LoggerFactory.getLogger(ElasticsearchSchemaFactory.class);
+ // RestClient objects allocate system resources and are thread safe. Here, we
+ // cache them using a key derived from the hashCode()s of the parameters that
+ // define a RestClient.
+ private static Cache<Integer, RestClient> restClients =
CacheBuilder.newBuilder()
+ .maximumSize(1000)
Review comment:
Thanks for the clarification. I think this PR is better than the former
one(as far as I can remember).
It's better not to force push before the final decision, so other reviewers
can take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
