rubenada commented on code in PR #2761:
URL: https://github.com/apache/calcite/pull/2761#discussion_r841763724
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -5848,8 +5848,8 @@ private void checkLiteral2(String expression, String
expected) {
+ "(SELECT \"department_id\"\n"
+ "FROM \"foodmart\".\"employee\"\n"
+ "GROUP BY \"department_id\") \"t1\"\n"
- + "GROUP BY \"t1\".\"department_id\") \"t3\" ON
\"employee\".\"department_id\" = \"t3\".\"department_id0\""
- + " AND \"employee\".\"department_id\" = \"t3\".\"EXPR$0\"";
+ + "GROUP BY \"t1\".\"department_id\"\n"
Review Comment:
Is this change (and the other changes in this file) expected because of the
patch?
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -5848,8 +5848,8 @@ private void checkLiteral2(String expression, String
expected) {
+ "(SELECT \"department_id\"\n"
+ "FROM \"foodmart\".\"employee\"\n"
+ "GROUP BY \"department_id\") \"t1\"\n"
- + "GROUP BY \"t1\".\"department_id\") \"t3\" ON
\"employee\".\"department_id\" = \"t3\".\"department_id0\""
- + " AND \"employee\".\"department_id\" = \"t3\".\"EXPR$0\"";
+ + "GROUP BY \"t1\".\"department_id\"\n"
Review Comment:
Is this change (and the other changes in this file) expected because of the
patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
