rubenada commented on code in PR #2761:
URL: https://github.com/apache/calcite/pull/2761#discussion_r841770982
##########
core/src/main/java/org/apache/calcite/rel/rules/FilterJoinRule.java:
##########
@@ -225,6 +232,91 @@ protected void perform(RelOptRuleCall call, @Nullable
Filter filter,
call.transformTo(relBuilder.build());
}
+ private static void inferJoinEqualConditions(List<RexNode> rexNodes, Join
join) {
Review Comment:
I'd suggest to add a small javadoc stating the purpose of this new method.
Also, like the already existing auxiliary method `validateJoinFilters`,
perhaps it should be protected and non-static, just in case rule's sub-classes
want to refine it.
##########
core/src/main/java/org/apache/calcite/rel/rules/FilterJoinRule.java:
##########
@@ -225,6 +232,91 @@ protected void perform(RelOptRuleCall call, @Nullable
Filter filter,
call.transformTo(relBuilder.build());
}
+ private static void inferJoinEqualConditions(List<RexNode> rexNodes, Join
join) {
Review Comment:
I'd suggest to add a small javadoc stating the purpose of this new method.
Also, like the already existing auxiliary method `validateJoinFilters`,
perhaps it should be protected and non-static, just in case rule's sub-classes
want to refine it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
