libenchao commented on code in PR #2829:
URL: https://github.com/apache/calcite/pull/2829#discussion_r893431505
##########
core/src/main/java/org/apache/calcite/sql2rel/RelDecorrelator.java:
##########
@@ -1595,6 +1590,7 @@ static Map<Integer, Integer> identityMap(int count) {
Frame register(RelNode rel, RelNode newRel,
Map<Integer, Integer> oldToNewOutputs,
NavigableMap<CorDef, Integer> corDefOutputs) {
+ newRel = RelOptUtil.copyRelHints(rel, newRel);
Review Comment:
@rubenada I have one concern about using `RelOptUtil#copyRelHints`, if
someday, we introduced another new `RelNode` and it's not `Hintable`, the hint
will still be lost. E.g. rel is `Hintable`, and `newRel` is not `Hintable`.
Do you think that we need to do some propagation instead of coping?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
