libenchao commented on code in PR #2829:
URL: https://github.com/apache/calcite/pull/2829#discussion_r893585420
##########
core/src/main/java/org/apache/calcite/sql2rel/RelDecorrelator.java:
##########
@@ -1595,6 +1590,7 @@ static Map<Integer, Integer> identityMap(int count) {
Frame register(RelNode rel, RelNode newRel,
Map<Integer, Integer> oldToNewOutputs,
NavigableMap<CorDef, Integer> corDefOutputs) {
+ newRel = RelOptUtil.copyRelHints(rel, newRel);
Review Comment:
> All in all, it seems the hint mechanism is still quite fragile, but IMHO
the current patch fixes at least one issue, so I'd propose to apply it to avoid
a regression, and maybe in the next release review the whole hint mechanism.
I agree with your point, please go ahead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
