rubenada commented on code in PR #2848:
URL: https://github.com/apache/calcite/pull/2848#discussion_r913566595
##########
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableLimit.java:
##########
@@ -96,11 +96,7 @@ public static EnumerableLimit create(final RelNode input,
@Nullable RexNode offs
final BlockBuilder builder = new BlockBuilder();
final EnumerableRel child = (EnumerableRel) getInput();
final Result result = implementor.visitChild(this, 0, child, pref);
- final PhysType physType =
- PhysTypeImpl.of(
- implementor.getTypeFactory(),
- getRowType(),
- result.format);
+ final PhysType physType = result.physType;
Review Comment:
This change does not seem related to CALCITE-5201
##########
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableSort.java:
##########
@@ -72,11 +72,7 @@ public static EnumerableSort create(RelNode child,
RelCollation collation,
final BlockBuilder builder = new BlockBuilder();
final EnumerableRel child = (EnumerableRel) getInput();
final Result result = implementor.visitChild(this, 0, child, pref);
- final PhysType physType =
- PhysTypeImpl.of(
- implementor.getTypeFactory(),
- getRowType(),
- result.format);
+ final PhysType physType = result.physType;
Review Comment:
This change does not seem related to CALCITE-5201
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
