rubenada commented on code in PR #2848:
URL: https://github.com/apache/calcite/pull/2848#discussion_r913813782
##########
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableLimit.java:
##########
@@ -96,11 +96,7 @@ public static EnumerableLimit create(final RelNode input,
@Nullable RexNode offs
final BlockBuilder builder = new BlockBuilder();
final EnumerableRel child = (EnumerableRel) getInput();
final Result result = implementor.visitChild(this, 0, child, pref);
- final PhysType physType =
- PhysTypeImpl.of(
- implementor.getTypeFactory(),
- getRowType(),
- result.format);
+ final PhysType physType = result.physType;
Review Comment:
I'm not sure to understand.
> The physical implementation for semi join and inner join is different in
EnumerableHashJoin, ...
Isn't the physical implementation for semi join and inner join always
different (independently of the Join implementation), because the inner will
include the RHS and the semi will not?
This change seems a bit ad-hoc. Why is it applied only on
{{EnumerableLimit}} and {{EnumerableSort}}, but we keep the "old code" in other
operators like {{EnumerableLimitSort}} or {{EnumerableAggregate}}?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
