goldmedal commented on code in PR #2883:
URL: https://github.com/apache/calcite/pull/2883#discussion_r956537645
##########
core/src/main/java/org/apache/calcite/sql/dialect/BigQuerySqlDialect.java:
##########
@@ -183,6 +183,15 @@ public BigQuerySqlDialect(SqlDialect.Context context) {
case TRIM:
unparseTrim(writer, call, leftPrec, rightPrec);
break;
+ case ITEM:
Review Comment:
> Besides, does `ORDINAL` only work in the array accessing in BigQuery? Are
there any other places that also need to be handled like this?
`ORIDANL` is an [Array subscript
operator](https://cloud.google.com/bigquery/docs/reference/standard-sql/operators#array_subscript_operator)
in BigQuery. I didn't see any other places needs this operator.
BTW, because `arrray subscript operator` has `ORDIANL`, `SAFE_ORDINAL`,
`OFFST` and `SAFE_OFFSET`, should we offer a config for the user to switch
which one is preferred?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
