libenchao commented on code in PR #2883:
URL: https://github.com/apache/calcite/pull/2883#discussion_r956656282
##########
core/src/main/java/org/apache/calcite/sql/dialect/BigQuerySqlDialect.java:
##########
@@ -183,6 +187,21 @@ public BigQuerySqlDialect(SqlDialect.Context context) {
case TRIM:
unparseTrim(writer, call, leftPrec, rightPrec);
break;
+ case ITEM:
+ if (call.operand(0) instanceof SqlBasicCall
Review Comment:
Sorry that I didn't realized that in `SqlDialect` we do not have validated
types. It's indeed not easy to know the operand's type here.
I would suggest that we go back to the JIRA to discuss the design first,
I'll post my concerns there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
