LeonidChistov commented on code in PR #2997:
URL: https://github.com/apache/calcite/pull/2997#discussion_r1039293894
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -672,9 +672,11 @@ private static String toSql(RelNode root, SqlDialect
dialect,
+ "FROM \"foodmart\".\"product\"\n"
+ "GROUP BY ROLLUP(\"product_class_id\", \"brand_name\")\n"
+ "ORDER BY \"product_class_id\", \"brand_name\"";
- final String expectedMysql = "SELECT `product_class_id`, `brand_name`\n"
+ final String expectedMysql = "SELECT *\n"
Review Comment:
That is probably excessive - if order of grouping fields matches the order
of sort fields, we can omit ORDER BY clause (as it was done in the old
solution).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
