wnob commented on code in PR #3003: URL: https://github.com/apache/calcite/pull/3003#discussion_r1066643024
########## core/src/main/java/org/apache/calcite/sql/fun/SqlIfNullFunction.java: ########## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to you under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.calcite.sql.fun; + +import org.apache.calcite.sql.SqlCall; +import org.apache.calcite.sql.SqlFunction; +import org.apache.calcite.sql.SqlFunctionCategory; +import org.apache.calcite.sql.SqlKind; +import org.apache.calcite.sql.SqlNode; +import org.apache.calcite.sql.SqlNodeList; +import org.apache.calcite.sql.parser.SqlParserPos; +import org.apache.calcite.sql.type.OperandTypes; +import org.apache.calcite.sql.type.ReturnTypes; +import org.apache.calcite.sql.type.SqlTypeTransforms; +import org.apache.calcite.sql.validate.SqlValidator; +import org.apache.calcite.util.Util; + +import java.util.List; + +/** + * The <code>IFULL</code> function. Review Comment: nit: maybe mention that this is for BigQuery. ########## core/src/main/java/org/apache/calcite/sql/fun/SqlIfNullFunction.java: ########## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to you under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.calcite.sql.fun; + +import org.apache.calcite.sql.SqlCall; +import org.apache.calcite.sql.SqlFunction; +import org.apache.calcite.sql.SqlFunctionCategory; +import org.apache.calcite.sql.SqlKind; +import org.apache.calcite.sql.SqlNode; +import org.apache.calcite.sql.SqlNodeList; +import org.apache.calcite.sql.parser.SqlParserPos; +import org.apache.calcite.sql.type.OperandTypes; +import org.apache.calcite.sql.type.ReturnTypes; +import org.apache.calcite.sql.type.SqlTypeTransforms; +import org.apache.calcite.sql.validate.SqlValidator; +import org.apache.calcite.util.Util; + +import java.util.List; + +/** + * The <code>IFULL</code> function. + */ +public class SqlIfNullFunction extends SqlFunction { + //~ Constructors + + public SqlIfNullFunction() { + super("IFNULL", + SqlKind.COALESCE, + ReturnTypes.LEAST_RESTRICTIVE.andThen(SqlTypeTransforms.LEAST_NULLABLE), + null, + OperandTypes.SAME_SAME, + SqlFunctionCategory.SYSTEM); + } + + //~ Methods ---------------------------------------------------------------- + + // override SqlOperator + @Override public SqlNode rewriteCall(SqlValidator validator, SqlCall call) { Review Comment: Oh cool, I didn't know about this. Super clean. ########## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ########## @@ -6315,6 +6315,30 @@ void assertSubFunReturns(boolean binary, String s, int start, f12.checkNull("nvl(CAST(NULL AS VARCHAR(6)), cast(NULL AS VARCHAR(4)))"); } + + @Test void testIfNullCoalesceFunc() { + final SqlOperatorFixture f = fixture() + .withLibrary(SqlLibrary.BIG_QUERY) + .setFor(SqlLibraryOperators.IFNULL, VM_EXPAND); + + f.checkString("ifnull('a','b')", "a", "CHAR(1) NOT NULL"); + f.checkString("ifnull(null,'b')", "b", "CHAR(1)"); Review Comment: nit: I'm a bit surprised that this isn't `NOT NULL`, since the javadoc for `LEAST_NULLABLE` says: "the result is NOT NULL if any of the arguments is NOT NULL; otherwise the type is unchanged" and it would seem the type of `'b'` should be `NOT NULL`. Any ideas as to why? Not sure if this is really a problem or not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
