bchong95 commented on code in PR #2953:
URL: https://github.com/apache/calcite/pull/2953#discussion_r1105141657
##########
core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java:
##########
@@ -7355,4 +7465,11 @@ private enum Clause {
ORDER,
CURSOR
}
+
+ /** Which clause is being expanded. */
Review Comment:
GroupByScope calls into the validator like so:
```
SqlNode expanded =
validator.extendedExpand(expr, this, select,
SqlValidatorImpl.Clause.GROUP_BY);
```
The enum has to be public.
Also we only expand GROUP BY , HAVING, and QUALIFY, so I made a separate
enum.
A workaround could be:
* Extend the Clause Enum
* Keep it Private
* Create overloads like extendedExpandGroupBy, extendedExpandQualify,
extendedExpandHaving ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
