julianhyde commented on code in PR #2953:
URL: https://github.com/apache/calcite/pull/2953#discussion_r1105173215
##########
core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java:
##########
@@ -7355,4 +7465,11 @@ private enum Clause {
ORDER,
CURSOR
}
+
+ /** Which clause is being expanded. */
Review Comment:
It makes sense to add `QUALIFY` to `enum Clause`. It is a new SQL clause,
after all.
If a method has a `Clause` parameter but does not accept all values, it can
use `Preconditions.checkArgument` or just `throw` in the `default:` clause of a
`switch`.
Are there any current or new uses outside the
`org.apache.calcite.sql.validate` package? If not, there's no need for
`public`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
