libenchao commented on code in PR #2994:
URL: https://github.com/apache/calcite/pull/2994#discussion_r1147670735
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -5972,16 +5972,7 @@ private void checkLiteral2(String expression, String
expected) {
final String expected = "SELECT COUNT(*)\n"
+ "FROM \"foodmart\".\"product\"\n"
+ "GROUP BY CUBE(\"product_id\", \"product_class_id\")";
- final String expectedInSpark = "SELECT COUNT(*)\n"
- + "FROM foodmart.product\n"
- + "GROUP BY product_id, product_class_id WITH CUBE";
- final String expectedPresto = "SELECT COUNT(*)\n"
- + "FROM \"foodmart\".\"product\"\n"
- + "GROUP BY CUBE(\"product_id\", \"product_class_id\")";
- sql(query)
- .ok(expected)
- .withPresto().ok(expectedPresto)
Review Comment:
Why need you remove the test for presto?
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -5972,16 +5972,7 @@ private void checkLiteral2(String expression, String
expected) {
final String expected = "SELECT COUNT(*)\n"
+ "FROM \"foodmart\".\"product\"\n"
+ "GROUP BY CUBE(\"product_id\", \"product_class_id\")";
- final String expectedInSpark = "SELECT COUNT(*)\n"
- + "FROM foodmart.product\n"
- + "GROUP BY product_id, product_class_id WITH CUBE";
Review Comment:
We have already support `WITH CUBE` and `WITH ROLLUP` in CALCITE-3077, will
the test still pass after your change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
