zoudan commented on code in PR #3099:
URL: https://github.com/apache/calcite/pull/3099#discussion_r1148716693


##########
core/src/main/codegen/default_config.fmpp:
##########
@@ -88,6 +88,8 @@ parser: {
     "DATETIME_DIFF"
     "DATETIME_INTERVAL_CODE"
     "DATETIME_INTERVAL_PRECISION"
+    "DAYOFWEEK"

Review Comment:
   this has nothing to do with `LOG`?



##########
babel/src/test/resources/sql/big-query.iq:
##########
@@ -371,6 +371,30 @@ SELECT EXTRACT(DAY FROM DATE '2013-12-25') AS the_day;
 
 !ok
 
+SELECT
+  EXTRACT(DAYOFWEEK FROM DATE '2008-12-25') as day_of_week,

Review Comment:
   This PR includes some changes which are not release to CALCITE-5565



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to