zinking commented on code in PR #3136:
URL: https://github.com/apache/calcite/pull/3136#discussion_r1164920809
##########
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##########
@@ -431,48 +431,59 @@ protected SqlOperatorFixture fixture() {
true);
}
- /** Tests that CAST and SAFE_CAST are basically equivalent but SAFE_CAST is
- * only available in BigQuery library. */
- @Test void testCastVsSafeCast() {
Review Comment:
in my understanding parameterized tests are better suited for this.
I'd suggest some refactoring into these tests. let's see what others think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
