olivrlee commented on code in PR #3136:
URL: https://github.com/apache/calcite/pull/3136#discussion_r1165806120
##########
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##########
@@ -431,48 +431,59 @@ protected SqlOperatorFixture fixture() {
true);
}
- /** Tests that CAST and SAFE_CAST are basically equivalent but SAFE_CAST is
- * only available in BigQuery library. */
- @Test void testCastVsSafeCast() {
Review Comment:
In this case the behavior of the functions (`SAFE_CAST`, `TRY_CAST`) are
identical, it is just named differently across dialects, so I am a fan of the
code reuse.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
