LeonidChistov commented on code in PR #3143:
URL: https://github.com/apache/calcite/pull/3143#discussion_r1166679796
##########
core/src/test/java/org/apache/calcite/rex/RexProgramTest.java:
##########
@@ -3288,6 +3288,57 @@ private void checkSarg(String message, Sarg sarg,
not(rexBuilder.makeCall(SqlStdOperatorTable.SIMILAR_TO, ref,
literal("%"))));
}
+ @Test void testSimplifyNullCheckInFilter() {
Review Comment:
I can do that, but actually it is not very clear for me, which style to
follow. I think that majority of the tests in this file are collected to large
methods, and also some of them have an honor to reside in their own method.
Are there any guidelines in Calcite regarding this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
