LeonidChistov commented on code in PR #3143:
URL: https://github.com/apache/calcite/pull/3143#discussion_r1166683641
##########
core/src/main/java/org/apache/calcite/rex/RexSimplify.java:
##########
@@ -1793,16 +1761,51 @@ private <C extends Comparable<C>> RexNode
simplifyAnd2ForUnknownAsFalse(
return rexBuilder.makeLiteral(false);
}
}
- // Add the NOT disjunctions back in.
- for (RexNode notDisjunction : notTerms) {
- terms.add(not(notDisjunction));
- }
// The negated terms: only deterministic expressions
for (RexNode negatedTerm : negatedTerms) {
if (termsSet.contains(negatedTerm)) {
return rexBuilder.makeLiteral(false);
}
}
+ // Add the NOT disjunctions back in.
Review Comment:
That's probably does not matter a lot, I have just moved it a bit closer to
the code where we actually need this.
I rely on having both `terms` and `notTerms` included to `terms` list during
calculation of `strongOperands`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
