rubenada commented on code in PR #3154:
URL: https://github.com/apache/calcite/pull/3154#discussion_r1169168746
##########
core/src/main/java/org/apache/calcite/adapter/java/ReflectiveSchema.java:
##########
@@ -235,6 +240,13 @@ private static Enumerable toEnumerable(final Object o) {
"Cannot convert " + o.getClass() + " into a Enumerable");
}
+ private static @Nullable Double toRowCount(final Object o) {
+ if (o.getClass().isArray()) {
Review Comment:
Would it make sense to consider also the case where `o` is a Collection and
return its size?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
