zoudan commented on code in PR #3154:
URL: https://github.com/apache/calcite/pull/3154#discussion_r1204946465
##########
core/src/test/java/org/apache/calcite/test/ReflectiveSchemaTest.java:
##########
@@ -63,9 +65,7 @@
import static org.hamcrest.CoreMatchers.equalTo;
import static org.hamcrest.CoreMatchers.is;
import static org.hamcrest.MatcherAssert.assertThat;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertTrue;
-import static org.junit.jupiter.api.Assertions.fail;
+import static org.junit.jupiter.api.Assertions.*;
Review Comment:
do not use `.* `
##########
core/src/main/java/org/apache/calcite/adapter/java/ReflectiveSchema.java:
##########
@@ -235,6 +240,13 @@ private static Enumerable toEnumerable(final Object o) {
"Cannot convert " + o.getClass() + " into a Enumerable");
}
+ private static @Nullable Double toRowCount(final Object o) {
Review Comment:
`toRowCount` -> `getRowCount` may be better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
