tanclary commented on code in PR #3125:
URL: https://github.com/apache/calcite/pull/3125#discussion_r1175495036
##########
babel/src/test/resources/sql/big-query.iq:
##########
@@ -398,14 +398,12 @@ SELECT
# In the following example, EXTRACT returns values corresponding to
# different date parts from a column of dates near the end of the
# year.
-
-!if (false) {
SELECT
d,
EXTRACT(ISOYEAR FROM d) AS isoyear,
- EXTRACT(ISOWEEK FROM d) AS isoweek,
- EXTRACT(YEAR FROM d) AS year,
- EXTRACT(WEEK FROM d) AS week
+ EXTRACT(ISOWEEK FROM d) as isoweek,
+ EXTRACT(WEEK(TUESDAY) FROM d) AS week_tues,
Review Comment:
Yes I could. I did a poor job of noting this but the reason I didn't do this
originally is because WEEK for the EXTRACT function is currently configured
incorrectly in Avatica. As it stands, EXTRACT(WEEK ...) actually returns the
ISOWEEK. This causes all tests for EXTRACT WEEK in Calcite to be off in some
cases where the ISOWEEK and WEEK for a given date happen to be different. I can
open a ticket for this issue if you think it is warranted?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
