rubenada commented on code in PR #3228:
URL: https://github.com/apache/calcite/pull/3228#discussion_r1209198034
##########
linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java:
##########
@@ -2732,6 +2732,7 @@ public static <TSource, TKey> Enumerable<TSource> orderBy(
// search the key up to (but excluding) which we have to remove
entries from the map
int skipped = 0;
TKey until = null;
+ boolean hasResult = false;
Review Comment:
I wonder if it would be clearer to keep the same approach in the code, but
just using another "unset value" instead of `null`, e.g. the `DUMMY` object
that already exists in the class:
```
TKey until = (TKey) DUMMY;
...
if (until == DUMMY)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
