rubenada commented on PR #3228:
URL: https://github.com/apache/calcite/pull/3228#issuecomment-1567926855
> Thank you very much for your suggestion! Jira's adjusted title is much
clearer. Sorry for my poor english. I have changed the PR title and commit
message to be consistent with Jira ticket.
No problem :)
I have added a comment in Jira with a test class with a test that
systematically reproduces the problem, could you please include it in the PR?
Also, since we are adding this new test class for `EnumerableLimitSortTest`, I
think it would be a nice bonus to include a couple of extra tests (even if they
are unrelated to the current bug) just to show other sql queries scenarios for
`EnumerableLimitSort` (nulls last, order on several columns, limit without
offset, ...); the {{HrSchemaBig}} that I used on the bug test should be enough
to provide all these scenarios.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
