liuyongvs commented on code in PR #3236:
URL: https://github.com/apache/calcite/pull/3236#discussion_r1212510671
##########
testkit/src/main/java/org/apache/calcite/sql/test/AbstractSqlTester.java:
##########
@@ -325,7 +325,7 @@ public static String buildQueryAgg(String expression) {
* @return Query that evaluates a scalar expression
*/
protected String buildQuery2(SqlTestFactory factory, String expression) {
- if (expression.matches("(?i).*(percentile_(cont|disc)|convert)\\(.*")) {
+ if
(expression.matches("(?i).*(percentile_(cont|disc)|convert|sort_array)\\(.*")) {
// PERCENTILE_CONT requires its argument to be a literal,
// so converting its argument to a column will cause false errors.
Review Comment:
comments:
why should change this.
it is because it will change the literal to column for example select
sort_array(array[1, 2], true) -> sort_array(array[p0, p1], p2) . the p2 is not
lieral
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
