tanclary commented on code in PR #3236:
URL: https://github.com/apache/calcite/pull/3236#discussion_r1213435538
##########
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java:
##########
@@ -3061,6 +3063,28 @@ private static class ReinterpretImplementor extends
AbstractRexCallImplementor {
}
}
+ /** Implementor for sort_array. */
+ private static class SortArrayImplementor extends AbstractRexCallImplementor
{
+ SortArrayImplementor() {
+ super("sort_array", NullPolicy.STRICT, false);
+ }
+
+ @Override Expression implementSafe(RexToLixTranslator translator,
+ RexCall call, List<Expression> argValueList) {
+ if (argValueList.size() == 2) {
+ return Expressions.call(
+ BuiltInMethod.SORT_ARRAY.method,
+ argValueList.get(0),
Review Comment:
Here is an example: you call the method and pass just the entire
`argValueList`
https://github.com/apache/calcite/blob/main/core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java#L3884
The function takes two arguments:
https://github.com/apache/calcite/blob/main/core/src/main/java/org/apache/calcite/util/BuiltInMethod.java#L449
But the argValueList has two elements so this matches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
