rubenada commented on PR #3228: URL: https://github.com/apache/calcite/pull/3228#issuecomment-1571490053
Thanks for your review, @thomasrebele ! And no problem at all, I also missed this during the review of EnumerableLimitSort. . @gf2121 what's the status here? Do you have time for the final minor changes that I requested on the new test class? > Minor request: could you make the non-bug-related tests a bit more varied: different offset/limit values (not always 1), use asc/desc on order by, use different columns (not always commission+salary) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
