rubenada commented on PR #3228: URL: https://github.com/apache/calcite/pull/3228#issuecomment-1568270272
@gf2121 overall looks good. I left you one minor comment to improve the new tests (to make them more varied). Apart from that, a couple of general comments (it is OK for this PR, but you might want to keep them in mind for your next PR): - Generally we launch the PR from a source branch which is created expressly for it (usually named after the Jira ticket number, or the description of the feature/bug). - Generally, it is better to refrain from doing force push during the review process, it is better to keep the commit history to facilitate an incremental review. At the end of the review, when the PR looks good to be merged, we squash commits into a single one and force push before the final merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
