JiajunBernoulli commented on code in PR #3212:
URL: https://github.com/apache/calcite/pull/3212#discussion_r1213835525
##########
core/src/main/java/org/apache/calcite/util/BuiltInMethod.java:
##########
@@ -629,6 +629,8 @@ public enum BuiltInMethod {
SUBMULTISET_OF(SqlFunctions.class, "submultisetOf", Collection.class,
Collection.class),
ARRAY_DISTINCT(SqlFunctions.class, "distinct", List.class),
+ ARRAY_MAX(SqlFunctions.class, "max", List.class),
Review Comment:
Oh, I just realized now that this name is not suitable.
`MULTISET_UNION_ALL` named as `multisetUnionAll`
ARRAY_MAX should be `arrayMax`, not `max`.
Please change other function names together `ARRAY_REVERSE`, `ARRAY_REPEAT`,
`ARRAY_DISTINCT`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
