liuyongvs commented on code in PR #3212:
URL: https://github.com/apache/calcite/pull/3212#discussion_r1213866726


##########
core/src/main/java/org/apache/calcite/util/BuiltInMethod.java:
##########
@@ -629,6 +629,8 @@ public enum BuiltInMethod {
   SUBMULTISET_OF(SqlFunctions.class, "submultisetOf", Collection.class,
       Collection.class),
   ARRAY_DISTINCT(SqlFunctions.class, "distinct", List.class),
+  ARRAY_MAX(SqlFunctions.class, "max",  List.class),

Review Comment:
   i does that because i refer to array_reverse implmented by snuyanzin, the 
function also names reverse. so i do it too @JiajunBernoulli do you think it is 
need? i can modify all



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to