liuyongvs commented on code in PR #3207:
URL: https://github.com/apache/calcite/pull/3207#discussion_r1221307371
##########
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##########
@@ -5364,6 +5364,31 @@ private static void checkIf(SqlOperatorFixture f) {
f.checkNull("array_concat(cast(null as integer array), array[1])");
}
+ /** Tests {@code ARRAY_CONTAINS} function from Spark. */
+ @Test void testArrayContainsFunc() {
+ final SqlOperatorFixture f0 = fixture();
+ f0.setFor(SqlLibraryOperators.ARRAY_CONTAINS);
+ f0.checkFails("^array_contains(array[1, 2], 1)^",
+ "No match found for function signature "
+ + "ARRAY_CONTAINS\\(<INTEGER ARRAY>, <NUMERIC>\\)", false);
+
+ final SqlOperatorFixture f = f0.withLibrary(SqlLibrary.SPARK);
+ f.checkScalar("array_contains(array[1, 2], 1)", true,
+ "BOOLEAN NOT NULL");
+ f.checkScalar("array_contains(array[1, null], cast(null as integer))",
true,
+ "BOOLEAN NOT NULL");
+ f.checkScalar("array_contains(array[1], 1)", true,
+ "BOOLEAN NOT NULL");
+ f.checkScalar("array_contains(array(), 1)", false,
+ "BOOLEAN NOT NULL");
+ f.checkScalar("array_contains(array[map[1, 'a'], map[2, 'b']], map[1,
'a'])", true,
+ "BOOLEAN NOT NULL");
Review Comment:
Due to implementation limitation, currently Spark can't compare or do
equality check between map types. As a result, map values can't appear in EQUAL
or comparison expressions, can't be grouping key, etc.()
while calcite Map runtime implementation using java collection Map, which
supports equality check. while spark not
```
/**
* This is an internal data representation for map type in Spark SQL. This
should not implement
* `equals` and `hashCode` because the type cannot be used as join keys,
grouping keys, or
* in equality tests. See SPARK-9415 and PR#13847 for the discussions.
*/
abstract class MapData extends Serializable {
```
https://github.com/apache/spark/pull/23045
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
