julianhyde commented on code in PR #3207:
URL: https://github.com/apache/calcite/pull/3207#discussion_r1220075533
##########
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##########
@@ -5364,6 +5364,31 @@ private static void checkIf(SqlOperatorFixture f) {
f.checkNull("array_concat(cast(null as integer array), array[1])");
}
+ /** Tests {@code ARRAY_CONTAINS} function from Spark. */
+ @Test void testArrayContainsFunc() {
+ final SqlOperatorFixture f0 = fixture();
+ f0.setFor(SqlLibraryOperators.ARRAY_CONTAINS);
+ f0.checkFails("^array_contains(array[1, 2], 1)^",
+ "No match found for function signature "
+ + "ARRAY_CONTAINS\\(<INTEGER ARRAY>, <NUMERIC>\\)", false);
+
+ final SqlOperatorFixture f = f0.withLibrary(SqlLibrary.SPARK);
Review Comment:
Good point, @tanclary. The validator should give an error if you - say -
search for a BOOLEAN in a DATE ARRAY. We should add a test case to this test
method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
