tanclary commented on code in PR #3238: URL: https://github.com/apache/calcite/pull/3238#discussion_r1223392544
########## site/_docs/reference.md: ########## @@ -2737,6 +2737,8 @@ BigQuery's type system uses confusingly different names for types and functions: | s | MAP_ENTRIES(map) | Returns the entries of the *map* as an array, the order of the entries is not defined | s | MAP_KEYS(map) | Returns the keys of the *map* as an array, the order of the entries is not defined | s | MAP_VALUES(map) | Returns the values of the *map* as an array, the order of the entries is not defined +| s | MAP_FROM_ARRAYS(array1, array2) | Returns a map created from an *array1* and *array2*. Note that the lengths of two arrays should be the same +| s | STR_TO_MAP(string[, stringDelimiter[, keyValueDelimiter]]) | Returns a map after splitting the *string* into key/value pairs using delimiters. Default delimiters are ',' for *stringDelimiter* and ':' for *keyValueDelimiter* Review Comment: nit: should there be spaces here? check other examples with optional args -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
