julianhyde commented on code in PR #3245:
URL: https://github.com/apache/calcite/pull/3245#discussion_r1224881785
##########
core/src/main/java/org/apache/calcite/sql/fun/SqlStdOperatorTable.java:
##########
@@ -1853,12 +1853,14 @@ public class SqlStdOperatorTable extends
ReflectiveSqlOperatorTable {
/**
* The <code>FLOOR</code> function.
*/
- public static final SqlFunction FLOOR = new SqlFloorFunction(SqlKind.FLOOR);
+ public static final SqlFunction FLOOR =
+ new SqlFloorFunction(SqlKind.FLOOR, ReturnTypes.ARG0_OR_EXACT_NO_SCALE);
Review Comment:
I would keep the same constructor, and add methods `withName`,
`withReturnTypeInference`. (We have discovered that for functions/operators,
subclassing doesn't scale, and adding constructor parameters doesn't scale.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
