julianhyde commented on code in PR #3245:
URL: https://github.com/apache/calcite/pull/3245#discussion_r1237732224
##########
site/_docs/reference.md:
##########
@@ -2661,6 +2661,7 @@ BigQuery's type system uses confusingly different names
for types and functions:
| s | ARRAY_SIZE(array) | Synonym for
`CARDINALITY`
| * | ASINH(numeric) | Returns the inverse
hyperbolic sine of *numeric*
| * | ATANH(numeric) | Returns the inverse
hyperbolic tangent of *numeric*
+| b | CEIL(value) | Similar to standard
`CEIL(value)` except if *value* is an integer type, the return type is a double
Review Comment:
add space before `|`
##########
core/src/main/codegen/templates/Parser.jj:
##########
@@ -7335,9 +7336,13 @@ SqlNode StandardFloorCeilOptions(Span s, boolean
floorFlag) :
}
)?
<RPAREN> {
- SqlOperator op = floorFlag
- ? SqlStdOperatorTable.FLOOR
- : SqlStdOperatorTable.CEIL;
+ SqlOperator op;
+ boolean isBigQuery = this.conformance.semantics() ==
SqlLibrary.BIG_QUERY;
Review Comment:
can you create a function in SqlStdOperatorTable similar to
`SqlStdOperatorTable.like(boolean,boolean)`? Its args should be boolean and
conformance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
