rubenada commented on code in PR #3258:
URL: https://github.com/apache/calcite/pull/3258#discussion_r1232054949


##########
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##########
@@ -1959,6 +1960,24 @@ private static void checkConcatFunc(SqlOperatorFixture 
f) {
     f.checkFails("^concat()^", INVALID_ARGUMENTS_NUMBER, false);
   }
 
+  /** Test case for
+   * <a 
href="https://issues.apache.org/jira/browse/CALCITE-5771";>[CALCITE-5771]
+   * Apply two different NULL semantics for CONCAT function(enabled in MySQL、

Review Comment:
   I think it would be better to use here the "regular comma":  `,`  instead of 
`、`
   The same applies for the similar messages in functions.iq, final commit 
message, PR title and Jira title. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to