julianhyde commented on code in PR #3303:
URL: https://github.com/apache/calcite/pull/3303#discussion_r1260238996
##########
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##########
@@ -2106,6 +2106,11 @@ public static boolean isInf(double b0) {
return Double.isInfinite(b0);
}
+ /** SQL <code>IS_INF</code> operator applied to float values. */
Review Comment:
do the tests pass if you remove the `isInf(float)` and `isNaN(float)`
methods? I suspect they will. If so, remove the methods. less is more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
