LakeShen commented on code in PR #3316:
URL: https://github.com/apache/calcite/pull/3316#discussion_r1266972865
##########
core/src/test/java/org/apache/calcite/rex/RexProgramTest.java:
##########
@@ -801,6 +804,17 @@ private void checkExponentialCnf(int n) {
and(eRef,
or(fRef,
and(gRef, or(trueLiteral, falseLiteral)))))))));
+
Review Comment:
> We should find a way to prevent regressions on this, and bake them into a
test that can run within Calcite, we cannot rely too much on such manual checks
as people come and go, while Calcite tests stay.
>
> I wonder then what's the extra part you added to the test is actually
checking if not predicate order.
Hi @asolimando ,the single test I added is the case shown in my picture
above,I improved the content of the single test I added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
