LakeShen commented on code in PR #3316:
URL: https://github.com/apache/calcite/pull/3316#discussion_r1279386104
##########
core/src/test/java/org/apache/calcite/rex/RexProgramTest.java:
##########
@@ -801,6 +804,17 @@ private void checkExponentialCnf(int n) {
and(eRef,
or(fRef,
and(gRef, or(trueLiteral, falseLiteral)))))))));
+
Review Comment:
Hi @asolimando Thank you very much for your patience to give me review
suggestions.
You are right that the RexUtil.CnfHelper#commonFactors method only called in
a single place,if it return the `LinkedHashMap<RexNode, RexNode> ` instead of
`Map<RexNode, RexNode>`,It can tell others that the results it returns are in a
deterministic order, it make sense to me,I will follow your suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
