rubenada commented on PR #3314: URL: https://github.com/apache/calcite/pull/3314#issuecomment-1669195183
Thanks @mihaibudiu , IMO the PR looks in a good shape. I'll merge it in the next days if no other remarks appear. BTW, as a general note, it's not a big deal but usually we prefer to keep the commit history in the PR (with several commits) to facilitate the work of reviewers who may want to take a look at the evolution and different steps taken during the review process. Once all remarks have been addressed and the PR is in a good shape and ready to merge, we ask to squash commits into a single one right before the merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
