chucheng92 commented on code in PR #3320:
URL: https://github.com/apache/calcite/pull/3320#discussion_r1292941176
##########
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##########
@@ -5845,6 +5845,84 @@ private static void checkIf(SqlOperatorFixture f) {
f.checkNull("array_except(cast(null as integer array), cast(null as
integer array))");
}
+ /** Tests {@code ARRAY_INSERT} function from Spark. */
+ @Test void testArrayInsertFunc() {
+ final SqlOperatorFixture f0 = fixture();
+ f0.setFor(SqlLibraryOperators.ARRAY_INSERT);
+ f0.checkFails("^array_insert(null, 3, 4)^",
+ "No match found for function signature "
+ + "ARRAY_INSERT\\(<NULL>, <NUMERIC>, <NUMERIC>\\)", false);
+ f0.checkFails("^array_insert(array[1], null, 4)^",
+ "No match found for function signature "
+ + "ARRAY_INSERT\\(<INTEGER ARRAY>, <NULL>, <NUMERIC>\\)", false);
+ f0.checkFails("^array_insert(array[1], 3, null)^",
+ "No match found for function signature "
+ + "ARRAY_INSERT\\(<INTEGER ARRAY>, <NUMERIC>, <NULL>\\)", false);
+
+ final SqlOperatorFixture f1 = f0.withLibrary(SqlLibrary.SPARK);
+
+ // can't be NULL
+ f1.checkFails("array_insert(^null^, 3, 4)",
+ "Argument to function 'ARRAY_INSERT' must not be NULL", false);
+ f1.checkFails("array_insert(array[1], ^null^, 4)",
+ "Argument to function 'ARRAY_INSERT' must not be NULL", false);
+ f1.checkFails("array_insert(array[1], 3, ^null^)",
+ "Argument to function 'ARRAY_INSERT' must not be NULL", false);
+
+ // return null
+ f1.checkNull("array_insert(cast(null as integer array), 3, 4)");
+ f1.checkNull("array_insert(array[1], cast(null as integer), 4)");
+
+ // op1 must be Integer type
+ f1.checkFails("^array_insert(array[1, 2, 3], cast(3 as tinyint), 4)^",
+ "TINYINT is not comparable to INTEGER", false);
+ f1.checkFails("^array_insert(array[1, 2, 3], cast(3 as smallint), 4)^",
+ "SMALLINT is not comparable to INTEGER", false);
+ f1.checkFails("^array_insert(array[1, 2, 3], cast(3 as bigint), 4)^",
+ "BIGINT is not comparable to INTEGER", false);
+ f1.checkFails("^array_insert(array[1, 2, 3], 3.0, 4)^",
+ "DECIMAL is not comparable to INTEGER", false);
+ f1.checkFails("^array_insert(array[1, 2, 3], '3', 4)^",
+ "CHAR is not comparable to INTEGER", false);
+ // op1 can't be 0
+ f1.checkFails("array_insert(array[2, 3, 4], 0, 1)",
+ "The index 0 is invalid. "
+ + "An index shall be either < 0 or > 0 \\(the first element has
index 1\\) "
+ + "and not exceeds the allowed limit.", true);
+ // op1 overflow
+ f1.checkFails("array_insert(array[2, 3, 4], 2147483647, 1)",
+ "The index 0 is invalid. "
+ + "An index shall be either < 0 or > 0 \\(the first element has
index 1\\) "
+ + "and not exceeds the allowed limit.", true);
+ f1.checkFails("array_insert(array[2, 3, 4], -2147483648, 1)",
+ "The index 0 is invalid. "
+ + "An index shall be either < 0 or > 0 \\(the first element has
index 1\\) "
+ + "and not exceeds the allowed limit.", true);
+
+ // op2 must be op0 array component type
+ f1.checkFails("^array_insert(array[1, 2, 3], 3, cast(4 as tinyint))^",
+ "INTEGER is not comparable to TINYINT", false);
+ f1.checkFails("^array_insert(array[1, 2, 3], 3, cast(4 as smallint))^",
+ "INTEGER is not comparable to SMALLINT", false);
+ f1.checkFails("^array_insert(array[1, 2, 3], 3, cast(4 as bigint))^",
+ "INTEGER is not comparable to BIGINT", false);
+ f1.checkFails("^array_insert(array[1, 2, 3], 3, 4.0)^",
+ "INTEGER is not comparable to DECIMAL", false);
+ f1.checkFails("^array_insert(array[1, 2, 3], 3, '4')^",
+ "INTEGER is not comparable to CHAR", false);
+
+ f1.checkScalar("array_insert(array[1, 2, 3], 3, 4)",
+ "[1, 2, 4, 3]", "INTEGER NOT NULL ARRAY NOT NULL");
+ f1.checkScalar("array_insert(array[1, 2, 3], 3, cast(null as integer))",
+ "[1, 2, null, 3]", "INTEGER ARRAY NOT NULL");
+ f1.checkScalar("array_insert(array[2, 3, 4], 1, 1)",
+ "[1, 2, 3, 4]", "INTEGER NOT NULL ARRAY NOT NULL");
+ f1.checkScalar("array_insert(array[1, 3, 4], -2, 2)",
+ "[1, 2, 3, 4]", "INTEGER NOT NULL ARRAY NOT NULL");
Review Comment:
when index is negative, it means 'prepends'.
array_insert(array[1, 3, 4], -2, 2) => [1, 2, 3, 4]
when we reversed the input array(positive index to use appends behavior):
array_insert(array[4, 3, 1], 2, 2) => [4, 3, 2, 1]
spark make sure the insert behavior can be equivalent from left or right.
however, [1, 3, 2, 4] is wrong. it's 'appends' behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
