chucheng92 commented on code in PR #3366:
URL: https://github.com/apache/calcite/pull/3366#discussion_r1301143768
##########
core/src/main/codegen/templates/Parser.jj:
##########
@@ -7462,6 +7462,8 @@ SqlIdentifier ReservedFunctionName() :
| <NTILE>
| <NULLIF>
| <OCTET_LENGTH>
+ | <PERCENTILE_CONT>
+ | <PERCENTILE_DISC>
Review Comment:
@libenchao thanks for reviewing. I get your point. CALCITE-5564
(https://github.com/apache/calcite/pull/3210) introduced PERCENTILE_CONT &
PERCENTILE_DISC as functions, it changed these 2 reserved keywords to
nonReservedKeywords to let PERCENTILE_CONT & PERCENTILE_DISC can be function
name without quoted backtick.
If we not put it in ReservedFunctionName, the CALCITE-5564 will be failed
unless we refactor CALCITE-5564. I think this is correct way, otherwise we need
use backtick to quote the PERCENTILE_DISC to call the function, flink also let
these 2 keywords in ReservedFunctionName. If I'm wrong or there is a better way
to solve this, pls correct me. thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
